From 48df2969677f00c2c9e49e199f8de384880804d5 Mon Sep 17 00:00:00 2001 From: Amaia Anabitarte Date: Mon, 25 Nov 2024 11:55:39 +0100 Subject: [PATCH] MDL-83733 blocks: 'Activity' non used selectors had been deleted --- .upgradenotes/MDL-83733-2024112510535598.yml | 8 +++ .../behat/behat_block_site_main_menu.php | 51 ----------------- .../behat/behat_block_social_activities.php | 55 ------------------- 3 files changed, 8 insertions(+), 106 deletions(-) create mode 100644 .upgradenotes/MDL-83733-2024112510535598.yml delete mode 100644 blocks/site_main_menu/tests/behat/behat_block_site_main_menu.php delete mode 100644 blocks/social_activities/tests/behat/behat_block_social_activities.php diff --git a/.upgradenotes/MDL-83733-2024112510535598.yml b/.upgradenotes/MDL-83733-2024112510535598.yml new file mode 100644 index 0000000000000..8206292421fc1 --- /dev/null +++ b/.upgradenotes/MDL-83733-2024112510535598.yml @@ -0,0 +1,8 @@ +issueNumber: MDL-83733 +notes: + block_site_main_menu: + - message: '''Activity'' selector in site_main_menu block has been deleted.' + type: removed + block_social_activities: + - message: '''Activity'' selector in social_activities block has been deleted.' + type: removed diff --git a/blocks/site_main_menu/tests/behat/behat_block_site_main_menu.php b/blocks/site_main_menu/tests/behat/behat_block_site_main_menu.php deleted file mode 100644 index 0580e24e0c57d..0000000000000 --- a/blocks/site_main_menu/tests/behat/behat_block_site_main_menu.php +++ /dev/null @@ -1,51 +0,0 @@ -. - -/** - * Behat steps definitions for block site main menu - * - * @package block_site_main_menu - * @category test - * @copyright 2016 Marina Glancy - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - */ - -// NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php. - -require_once(__DIR__ . '/../../../../lib/behat/behat_base.php'); - -/** - * Behat steps definitions for block site main menu - * - * @package block_site_main_menu - * @category test - * @copyright 2016 Marina Glancy - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - */ -class behat_block_site_main_menu extends behat_base { - /** - * Return the list of partial named selectors. - * - * @return array - */ - public static function get_partial_named_selectors(): array { - return [ - new behat_component_named_selector('Activity', [ - "//*[contains(concat(' ',normalize-space(@class),' '),' block_site_main_menu ')]//li[contains(., %locator%)]" - ]), - ]; - } -} diff --git a/blocks/social_activities/tests/behat/behat_block_social_activities.php b/blocks/social_activities/tests/behat/behat_block_social_activities.php deleted file mode 100644 index 1e64e6e491f83..0000000000000 --- a/blocks/social_activities/tests/behat/behat_block_social_activities.php +++ /dev/null @@ -1,55 +0,0 @@ -. - -/** - * Behat steps definitions for block social activities - * - * @package block_social_activities - * @category test - * @copyright 2016 Marina Glancy - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - */ - -// NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php. - -require_once(__DIR__ . '/../../../../lib/behat/behat_base.php'); - -use Behat\Mink\Exception\ExpectationException as ExpectationException, - Behat\Mink\Exception\DriverException as DriverException, - Behat\Mink\Exception\ElementNotFoundException as ElementNotFoundException; - -/** - * Behat steps definitions for block social activities - * - * @package block_social_activities - * @category test - * @copyright 2016 Marina Glancy - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - */ -class behat_block_social_activities extends behat_base { - /** - * Return the list of partial named selectors. - * - * @return array - */ - public static function get_partial_named_selectors(): array { - return [ - new behat_component_named_selector('Activity', [ - "//*[contains(concat(' ',normalize-space(@class),' '),' block_social_activities ')]//li[contains(., %locator%)]", - ]), - ]; - } -}