Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oembed fails on Soundcloud #65

Open
markfinger opened this issue Oct 15, 2015 · 0 comments
Open

Oembed fails on Soundcloud #65

markfinger opened this issue Oct 15, 2015 · 0 comments
Labels

Comments

@markfinger
Copy link

Given a url https://soundcloud.com/vvv/faded-inscription-feat-bvitae, the following error is raised: ValueError: invalid literal for int() with base 10: '100%'.

The underlying issue seems to be that soundcloud's oembed implementation[0] differs from the spec[1], and they return a string which cannot be coerced to an int.

They return 100% for the width field, unfortunately the respective field on the fluent-contents model is an IntegerField and the coercing fails.

[0] https://developers.soundcloud.com/docs/oembed#introduction
[1] http://oembed.com/#section2 2.3.4.4. The rich type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants