Validation check problem with custom exceptions

[char-pap]

There is a problem occuring with the validation checker. The current one:

def _check_validatation_data(self, data):
        detail_key = "detail"  
        if detail_key in data:  
            return False  
        return True

checks only for 'detail' inside the data and this creates a problem when a custom exception handling exists or even if some response actually has the key "detail" inside.

Proposal: Validate via the response status code. If it is in the range of HTTP 2xx it's True.

[Azmisov]

I ran into this issue. My solution is to patch the renderer as:

class XLSXRendererPatch(XLSXRenderer):
    """ Modification on base XLSX renderer to prevent it from serializing exceptions as xlsx;
        see https://github.com/django-commons/drf-excel/issues/26
    """
    def render(self, data, accepted_media_type=None, renderer_context=None):
        if (
            (renderer_context and (ctx := renderer_context.get('response')) and ctx.status_code != 200) or
            (isinstance(data, dict) and ('error' in data or 'error_code' in data))
        ):
            self.media_type = 'application/json'
            return json.dumps(data)
        return super().render(data, accepted_media_type, renderer_context)

This checks HTTP 200 response, and also for non-presence of error/error_code. Additionally, I needed to change the media_type or it would send the default xlsx content type back for the JSONified error.

You may also need to get rid of XLSXFileMixin, or patch that as well, since it seems to try and fetch a filename for the content disposition header.