-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Grid compatibility for django CMS v4 plugin architecture #126
Merged
marksweb
merged 1 commit into
django-cms:support/django-cms-4.0.x
from
Aiky30:feature/cms-4-support
Nov 2, 2021
Merged
fix: Grid compatibility for django CMS v4 plugin architecture #126
marksweb
merged 1 commit into
django-cms:support/django-cms-4.0.x
from
Aiky30:feature/cms-4-support
Nov 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Error Log:
|
Aiky30
changed the title
WIP: Forward compatibility for django CMS v4
feat: Forward compatibility for django CMS v4
Oct 10, 2021
Aiky30
changed the title
feat: Forward compatibility for django CMS v4
fix: Grid compatibility for django CMS v4 plugin architecture
Oct 10, 2021
@crydotsnake Your issue raised here has been moved to a separate issue to help unblock the changes fixed in this PR. |
marksweb
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error thrown when trying to create a plugin using the bootstrap grid:
AttributeError at /admin/cms/placeholder/add-plugin/
'Bootstrap4GridRow' object has no attribute 'numchild'