Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button tag render #150

Open
khrizo opened this issue Feb 17, 2022 · 1 comment
Open

Button tag render #150

khrizo opened this issue Feb 17, 2022 · 1 comment

Comments

@khrizo
Copy link

khrizo commented Feb 17, 2022

I was trying to get <button></button> rendered in the front end when selecting a button plugin, instead I get <a href=""></a> with class="btn". I'm not sure if there is a better way to do this.

{% if instance.link_type == "btn" %}button{% else %}a href="{{ link }}"{% endif %} Opening tag
{% if instance.link_type == "btn" %} data-link="{{ link }}"{% endif %} Optional
{% if instance.link_type == "btn" %}button{% else %}a{% endif %} Closing tag

@fsbraun
Copy link
Member

fsbraun commented Mar 10, 2022

I'm not sure why you would prefer a button tag. A button cannot have a href which means you would need to add custom js to make it work. In bootstrap the <a class="btn btn-primary">...</a> is the canonical way to have a link which look like a button. Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants