-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap version 5 #125
Comments
Any news on this? |
Hello, Currently there are no plans for this yet. |
oh that's surprising as bootstrap 5 has just been released. Is it unpolite to ask why there are no plans to follow this step with djangocms? |
Hi everbody (@MicicFilip, @pietzschke, @zkne, @devyntk, @Mih333, @Gromph) I would like to briefly clarify a few things :-) The django CMS project has been fully backed by the community for a year now (find out more about the launch of the django CMS Association here). This means that all issues related to the development of django CMS and its plugin ecosystem rely on the work of our contributors. In order to facilitate the contribution process, we have initiated various work groups around different development topics. In terms of Bootstrap 5, no group has come together yet. So if anyone is interested in working on Bootstrap 5 compatibility, you are more than welcome to join us on Slack and I will happily guide you through the contribution process :-) By the way, we reward contributors who create pull requests with merch (see here). Thx PS: I know that @crydotsnake message does sound a bit harsh but since I know him I'm sure he didn't mean it that way 👍. |
I already created a repo for that, but i havent started yet: https://github.com/crydotsnake/djangocms-bootstrap5 |
@crydotsnake I'd be happy to help although my abilities and time is/are limited. But you can count on me for smaller tasks. |
Thanks a Lot @speendo ! :) |
Hello, Due to a need to have working carousel and other items, I've put together, based on this current repo, a Bootstrap 5 version. It has been completely renamed, and many of the changes required to support bootstrap 5 (data-* to data-bs-* for example). You can review it here and pull. |
That's actually quite amazing @gl-agnx :-) I have added you to the respective slack channel for further discussion. |
@gl-agnx Bravo! |
Hello @gl-agnx, How do you have tested your package? |
Hi, I've been running it with a compiled custom bootstrap 5.1.0 styling. I initially tested it with a CDN variant. |
All of the components aren't working. The idea is, that you add the Bootstrap Framework itself too your project, and the components in djangocms-boostrap5 should render in the normal bootstrap style. If you for example including Bootstrap 4, and use a Jumbotron Component from the djangocms-bootstrap4 package you will see, the styling works immediately. |
Hi @crydotsnake For me this works. I have everything rendering as expected in a site with a custom 5.0.1 CSS based on bootstrap (has some styling but most things are standard). But I didn't use pip or any package management. I dropped the directory inside my project (copied from the repo) Can you provide me with steps you use to run this so I can reproduce and find the issue? |
@gl-agnx Use the djangocms Quickstart and include Bootstrap 5 via CDN. |
I ran the quickstart docker but I can't get any connection to the python server running at port 8000 web_1 | 2021-09-26T08:15:56.020802032Z Watching for file changes with StatReloader |
@pietzschke check out djangocms-frontend for bootstrap5 support & migration from our old bootstrap4 app. |
Does djangocms bootstrap 5 would work with django 4.2.6 |
@rdawad check out this package for bootstrap 5 |
Hi there,
are there any plans to upgrade the plugin for bootstrap version 5 or to create an additional plugin for djangocms?
https://blog.getbootstrap.com/2020/06/16/bootstrap-5-alpha/
Looks like v5 will be out for beta soon:
https://github.com/twbs/bootstrap/projects/26
The text was updated successfully, but these errors were encountered: