Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute free entity configuration #183

Open
Wuerike opened this issue Oct 8, 2022 · 5 comments
Open

Attribute free entity configuration #183

Wuerike opened this issue Oct 8, 2022 · 5 comments
Labels
enhancement new feature or request up for grabs feature requires community contribution

Comments

@Wuerike
Copy link

Wuerike commented Oct 8, 2022

In my use case:

  • I wanna keep domain models free of db related annotations
  • I wanna avoid write the same model twice, at domain and at infra (+ annotations)

This is the code I wanna avoid

[Collection("transactions")]
public class SaleDto : Entity
{
    [Field("sale_id")]
    public string SaleId { get; set; }

    [Field("authorization_date")]
    public DateTime AuthorizationDate { get; set; }

}

The default driver support this with BsonClassMap (ref)

  • Class with annotation
public MyClass 
{
    // fields and properties
    [BsonExtraElements]
    public BsonDocument CatchAll { get; set; }
}
  • Equivalent of it but with mapping
BsonClassMap.RegisterClassMap<MyClass>(cm => 
{
    cm.AutoMap();
    cm.MapExtraElementsMember(c => c.CatchAll);
});
@dj-nitehawk
Copy link
Owner

it's currently not possible with this library.
will look in to supporting it at a future time.

@dj-nitehawk dj-nitehawk added the enhancement new feature or request label Oct 8, 2022
@dj-nitehawk dj-nitehawk changed the title Apply Attribute free entity configuration Oct 8, 2022
@dj-nitehawk dj-nitehawk added the up for grabs feature requires community contribution label Oct 8, 2022
@Wuerike
Copy link
Author

Wuerike commented Oct 8, 2022

If you give me a hint of how it can be done, maybe I can colaborate with it

@dj-nitehawk
Copy link
Owner

if I'm not mistaken, we need to look at all the places where the [Collection] attribute is being used and figure out a way to get that info without relying on the attribute. good thing we have good test coverage. so if the tests pass, with whatever changes we make, we should be ok to proceed with that approach.

also need to check if any other custom attributes are being relied on in our code.

@AS2AamjadPinjari
Copy link

any update on this?

@kavatari
Copy link

kavatari commented Nov 4, 2023

Would love to help here, just need some guidance to start. Will have a look into the Collections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature or request up for grabs feature requires community contribution
Projects
None yet
Development

No branches or pull requests

4 participants