Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic ref with @processing-role = 'resource-only' are processed #35

Open
blefort-uo opened this issue Jan 15, 2015 · 5 comments
Open

Topic ref with @processing-role = 'resource-only' are processed #35

blefort-uo opened this issue Jan 15, 2015 · 5 comments
Labels

Comments

@blefort-uo
Copy link
Contributor

Is it normal behaviour for pub ?

Should I replace the xpath expression for the template mode="generate-content"?

match="*[df:class(., 'map/topicref')]">

by

match="*[df:class(., 'map/topicref')][not(@processing-role = 'resource-only')]
@drmacro
Copy link
Member

drmacro commented Jan 15, 2015

It depends on what you're doing with the topicref.

processing-role of "resource-only" means "this resource is a dependency but is not directly processed", so in most cases you would want to ignore that topicref.

Likewise, a scope of "peer" or "external" should be ignored in most cases (in a pre-processed map "peer" would normally only appear on maprefs to peer maps, something that is not defined as meaningful in DITA 1.2 but is in DITA 1.3).

@blefort-uo
Copy link
Contributor Author

So would it be better to have this in a customization plugin rather than the epub transform ?

I really like the result, by the way. Our team was impressed too by your work !

I used them in the HTML5 plugin to render content in the background, but not linked them to the content. I render them contextually by javascript .

@drmacro
Copy link
Member

drmacro commented Jan 15, 2015

Not sure which part of the code you're concerned with, but the base EPUB code (and all the map-driven transforms) should be consistent in how they handle topicrefs.

I may not have scrubbed the EPUB code sufficiently in my recent updates for peer and external topicref support.

@blefort-uo
Copy link
Contributor Author

So I think, there is one inconsistency, because all topics with @processing-role = 'resource-only' are rendered in the epub.

I can send you an example if you wish.

@drmacro
Copy link
Member

drmacro commented Jan 15, 2015

There be an SourceForge issue for that. Definitely needs to be fixed if true.

@drmacro drmacro added the bug label Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants