Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose /etc/docker/registry as a volume #167

Open
aol-nnov opened this issue Jun 2, 2024 · 4 comments
Open

Expose /etc/docker/registry as a volume #167

aol-nnov opened this issue Jun 2, 2024 · 4 comments

Comments

@aol-nnov
Copy link

aol-nnov commented Jun 2, 2024

... to allow providing config.yml via volume in, say, docker-compose.

By now, constructs like

    volumes:
      - registry-config:/etc/docker/registry/

have no effect and volume with config.yml does not override the shipped file.

@milosgajdos
Copy link
Member

Im not sure I follow but we have integration tests in the dist repo and never had a problem with this https://github.com/distribution/distribution/blob/675d7e27f59c9d332418315adb20f02c20593cea/tests/docker-compose-e2e-cloud-storage.yml#L40-L61

@aol-nnov
Copy link
Author

aol-nnov commented Jun 2, 2024

@milosgajdos, to my understanding, conf-e2e-cloud-storage.yml in the aforementioned test is a file on the local fs. I propose storing it in the docker volume.

I.e. adding /etc/docker/registry/ here

@milosgajdos
Copy link
Member

I get what you want, but I'm not sure why or what problem will that solve for users.

@aol-nnov
Copy link
Author

aol-nnov commented Jun 3, 2024

I get what you want, but I'm not sure why

If one is controlling remote docker daemon (i.e. DOCKER_HOST=ssh://remote docker compose up -d) the approach you're referring to simply does not work. That's all...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants