Skip to content
This repository has been archived by the owner on Jun 20, 2018. It is now read-only.

UI is broken for switches having dots in their name, adding a new condition fails #72

Open
Raekkeri opened this issue Jun 3, 2013 · 2 comments

Comments

@Raekkeri
Copy link

Raekkeri commented Jun 3, 2013

Functionality (that depends on jQuery) to control Switches seems to be broken for any switch that have "dot" character in its name (e.g. "blog.comments.globally_disabled"). Can anyone reproduce? The bug seem to have appeared after commit d9d8277. Anyone seeing a solution that would be backwards compatible for anyone actually using the element ids?

@Raekkeri
Copy link
Author

Raekkeri commented Jun 4, 2013

Updating jQuery (in Nexus) to a newer version probably fixes the issue, see http://bugs.jquery.com/ticket/7533 (Nexus uses jQuery 1.4.4)

@Raekkeri
Copy link
Author

Raekkeri commented Jun 6, 2013

So, plan to fix this would be to

  1. update gargoyle.js file so that its syntax is correct for jQuery version 1.6.4 (see pull request Wrap id's of selectors in quotes #73). This should be backwards compatible with jQuery 1.4.4.
  2. then update jQuery version in Nexus to 1.6.4 (newer jQuery version doesn't work as its API has changed too much) (this change is currently only in my forked repo: Raekkeri/nexus@eeb3ac0)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant