fix handling of external refs targeting member shapes #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: I think we go with this for the time being and can revisit later if someone comes up with a nicer approach. |
Add some helper to extract from list
daddykotex
approved these changes
Sep 13, 2023
daddykotex
reviewed
Sep 13, 2023
| import cats.data.Chain | ||
| import scala.annotation.tailrec | ||
|
|
||
| /** This transformer is for the specific case where an external reference |
There was a problem hiding this comment.
as I recall from our discussion, this only happens if B$b is a primitive right?
can we state that in the doc or we don't want to because it may happen in other instances and we're not sure
There was a problem hiding this comment.
Yeah I will add it to the doc. It is that way since we match on the NewType on line 95 below and at this point in the postprocessing, all primitives are wrapped in newtypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes case where an external reference is pointing to a member shape targeting a primitive type.