Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies #9

Open
kubukoz opened this issue Sep 27, 2024 · 3 comments
Open

Missing dependencies #9

kubukoz opened this issue Sep 27, 2024 · 3 comments

Comments

@kubukoz
Copy link
Member

kubukoz commented Sep 27, 2024

We are missing dependencies for some services in:

override def ivyDeps: T[Agg[Dep]] = Agg(
ivy"software.amazon.smithy:smithy-aws-traits:$smithyVersion",
ivy"software.amazon.smithy:smithy-aws-cloudformation-traits:$smithyVersion",
ivy"software.amazon.smithy:smithy-aws-iam-traits:$smithyVersion",
ivy"software.amazon.smithy:smithy-waiters:$smithyVersion"
)

namely:

  • smithy-rules-engine
  • smithy-aws-endpoints

Example: Location service: https://github.com/aws/aws-sdk-js-v3/blob/b06a8b7d9d2a0ca2fc73acdbf37220575b0f1945/codegen/sdk-codegen/aws-models/location.json

@kubukoz
Copy link
Member Author

kubukoz commented Sep 30, 2024

as discussed in disneystreaming/smithy4s#1597, rules-engine isn't needed. The other thing I'll add in #11.

@kubukoz
Copy link
Member Author

kubukoz commented Sep 30, 2024

aaaaaaand we have a new one: smithy-aws-smoke-test-model (brings in smithy-smoke-test-traits).

@Baccata should these also get the aws.cloudformation treatment (being generated in smithy4s's aws kernel), or the smithy.rules treatment (being stripped from the model)?

@Baccata
Copy link
Contributor

Baccata commented Oct 1, 2024

The latter I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants