Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove name from suggestions as soon as it is typed fully #37

Open
rualark opened this issue May 27, 2020 · 2 comments
Open

Do not remove name from suggestions as soon as it is typed fully #37

rualark opened this issue May 27, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@rualark
Copy link

rualark commented May 27, 2020

If name is removed, typing full name and pressing Enter selects another name

@lahmatiy
Copy link
Member

If we don't remove a variant, so enter will have no effect and suggestion popup will be with no changes like something broken. Not sure that's better than current behaviour.

@rualark
Copy link
Author

rualark commented May 27, 2020

Enter should always close suggestion popup - this is a visual effect.
Example: I have two fields, 'filter' and 'filter_id'

Current behavior:

  • After typing 'filter', 'filter' is removed from suggestions and then pressing Enter inputs 'filter_id'

Desired behavior:

  • After typing 'filter', 'filter' is not removed from suggestions and then pressing Enter inputs 'filter'

Example in vscode:
image

@lahmatiy lahmatiy added the enhancement New feature or request label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants