Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Rotten Tomatoes ratings #3

Open
pzerou opened this issue Apr 4, 2020 · 2 comments
Open

Feature Request: Rotten Tomatoes ratings #3

pzerou opened this issue Apr 4, 2020 · 2 comments

Comments

@pzerou
Copy link

pzerou commented Apr 4, 2020

Might there be an ability to configure and/or include the Rotten Tomatoes rating in Movie queries?

On a related note, there is a RT discord app that worked at one time, but now having issues. Perhaps join powers and integrate into one DMDb super app?

https://github.com/WilliamWelsh/RottenTomatoes

@jaye
Copy link
Contributor

jaye commented Apr 5, 2020

I appreciate the feature request. I intended to add this a while ago but ran into some brick walls.

The current API that DMDb is using does not provide Rottem Tomato data. RT also doesn't have a publicly documented API anymore and I doubt DMDb would be eligible to access their private one. The unofficial API I was planning on using was very unstable at the time but I think it's doing well now.

Though, I'm not sure if it's worth sending another request for just an extra rating. I could, perhaps, create an option to enable RT data in the response.

I'll look into it more and see what I can do.

@pzerou
Copy link
Author

pzerou commented Apr 9, 2020

Do understand the added cost of separate calls possibly not being worth just the added rating, to an already existing description, etc. Makes sense.

To be fully transparent, the other bot dedicated to RT did since resolve whatever problem it had. So perhaps two independent bots, with their own value, isn't a bad thing.

WilliamWelsh/RottenTomatoes#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants