Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while evaluating a function for :table should exclude a row or show a special error row, not kill the whole table #398

Open
byorgey opened this issue Jul 19, 2024 · 0 comments
Labels
C-Low Hanging Fruit Shouldn't take too much time; ideal issues for new contributors. S-Nice to have Minor importance Z-Feature Request Z-Student Good project for a student.

Comments

@byorgey
Copy link
Member

byorgey commented Jul 19, 2024

Here is the current result when asking for a table for mod:

Disco> :table mod
Error: division by zero

That is, when making a table for mod, we happen to try something where the second input is zero, which causes a division by zero error. That's fine, but this should only cause us to discard that particular row, or even show a special error row, rather than discard the entire table. So, something like this:

Disco> :table mod
0  0  Error
0  1  0
1  0  Error
0  2  0
1  1  0
2  0  Error
0  3  0
1  2  1
2  1  0
3  0  Error
...
@byorgey byorgey added C-Low Hanging Fruit Shouldn't take too much time; ideal issues for new contributors. Z-Feature Request S-Nice to have Minor importance Z-Student Good project for a student. labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Low Hanging Fruit Shouldn't take too much time; ideal issues for new contributors. S-Nice to have Minor importance Z-Feature Request Z-Student Good project for a student.
Projects
None yet
Development

No branches or pull requests

1 participant