Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light Mode is not seen in home page #2

Open
dipak-kumawat opened this issue Aug 5, 2024 · 2 comments
Open

Light Mode is not seen in home page #2

dipak-kumawat opened this issue Aug 5, 2024 · 2 comments
Assignees
@dipak-kumawat
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@dipak-kumawat
Copy link
Owner

image
@dipak-kumawat dipak-kumawat added documentation Improvements or additions to documentation good first issue Good for newcomers labels Aug 5, 2024
@dipak-kumawat dipak-kumawat self-assigned this Aug 5, 2024
ayushsharma08 added a commit to ayushsharma08/YouTube that referenced this issue Aug 6, 2024
@ayushsharma08
"fix(theme): correct theme toggle logic in App component
7bb7e5a 
Ensure that the ThemeProvider correctly toggles between darkTheme and lightTheme based on the darkMode state. This fixes the issue where the light theme was not being applied correctly.

- Updated ThemeProvider to use darkTheme when darkMode is true and lightTheme when darkMode is false.
- Verified theme objects in utils/Thame.js are properly structured.
- Checked for any conflicting global styles.

Resolves: [dipak-kumawat#2 ]"
@ayushsharma08 ayushsharma08 mentioned this issue Aug 6, 2024
Merged
@dipak-kumawat
Copy link
Owner Author

Please review the main.jsx file to ensure the scroll effect is applied correctly. Additionally, ensure that the user can scroll smoothly and that the dark mode option is visible.
image

@dipak-kumawat
Copy link
Owner Author

Dark mode is working properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dipak-kumawat dipak-kumawat

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dipak-kumawat