Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to MavenCentral? #293

Open
jonamireh opened this issue Feb 8, 2021 · 12 comments
Open

Move to MavenCentral? #293

jonamireh opened this issue Feb 8, 2021 · 12 comments

Comments

@jonamireh
Copy link

Starting from May 1, 2021 jCenter & Bintray will stop working. I was looking for the williamchart artifact in MavenCentral and only found a few older versions. Are there any plans to upload more recent versions to MavenCentral?

@diogobernardino
Copy link
Owner

I intend to do the migration but unfortunately I'm already running late. I will nevertheless keep it on my list to do ASAP.

@ugurcany
Copy link

definitely need that migration. thanks in advance.

@diogobernardino
Copy link
Owner

Since better late than never... the core 3.10.1 dependency should already be visible in MavenCentral. Tooltip dependencies have to follow.

image

@CarlosVF2
Copy link

Hi @diogobernardino , are the toolTip dependecies upload to mavenCentral?? Thanks in advance.

@diogobernardino
Copy link
Owner

No, I haven't done it yet.

@diogobernardino
Copy link
Owner

image

Plugins are also migrated now.

@CarlosVF2
Copy link

Thanks a lot for your time and work!

@CarlosVF2
Copy link

HI @diogobernardino again!

Im sorry but I can't use the tooltip. I've in my app gradle dependencies this lines:

implementation group: 'com.diogobernardino.williamchart', name: 'tooltip-slider', version: '3.10.1'
implementation group: 'com.diogobernardino.williamchart', name: 'tooltip-points', version: '3.10.1'

And the project gradle this repository:

buildscript {
repositories {
maven { url "https://mvnrepository.com/artifact/" } //Williamchart
jcenter() {
content {
content {
includeModule("com.joanfuentes", "HintCase")//Solo hay version en Jcenter (https://mvnrepository.com/artifact/com.joanfuentes.hintcase/HintCase)
includeModule("com.joanfuentes", "HintCaseAssets") //Solo hay version en Jcente
//includeModule("com.diogobernardino", "williamchart") // https://mvnrepository.com/artifact/com.diogobernardino/williamchart versiones -> 1.7.x, 2.0.x, 2.1.x, 2.2.x,3.10.x pero no la versión 2.5 que se usa actualmente
}
}
}
// Crashlytics
mavenCentral()
.....
}
But always thow this error,

'https://mvnrepository.com/artifact/williamchart/williamchart/unspecified/williamchart-unspecified.pom'.

Do you know something about it?
Thanks a lot.

@diogobernardino
Copy link
Owner

Your gradle configuration seems a bit different than what I'm used to, nevertheless, the best would be to have a look at the dev branch of the sample project and compare it with yours. Note that you have to comment the local dependency and remove the comment from the maven one.

@CarlosVF2
Copy link

Hi @diogobernardino ,

Thanks for your reply one more time. I've pulled the branch dev of your repository and descomment the lines and comment the local dependencies. Furthermore, I comment the line of jcenter() in all projects from the repositories and happens exactly the same. It throws the error:

Execution failed for task ':mobile:checkDebugAarMetadata'.

Could not resolve all files for configuration ':mobile:debugRuntimeClasspath'.
Could not find williamchart:williamchart:unspecified.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/williamchart/williamchart/unspecified/williamchart-unspecified.pom
- https://repo.maven.apache.org/maven2/williamchart/williamchart/unspecified/williamchart-unspecified.pom
Required by:
project :mobile > com.diogobernardino.williamchart:tooltip-slider:3.10.1
project :mobile > com.diogobernardino.williamchart:tooltip-points:3.10.1

Possible solution:

Is it possible that doesn't migrate correctly to mavenCentral?

Thanks in advance.

@diogobernardino
Copy link
Owner

Let's try again. I published it under version 3.11.0. dev branch is up-to-date with the latest changes. I didn't remove jcenter() because it's still needed by detekt, but I was able to comment it out and still use 3.11.0 dependencies.

@CarlosVF2
Copy link

Hi @diogobernardino ,

Thanks a lot! the problem has solved, actually I need to migrate to that version from the version 2.5.0, that it's really old.

Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants