You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 18, 2019. It is now read-only.
It would be nice to have the "Results" table in the README kept up to date. For instance, a Rust implementation was recently added (#14), and there's a pull request to improve said implementation (#5).
Obviously, this could be a CI task, but maybe the simpler thing to do is update the README in any pull request which changes/adds implementation(s)? For consistency across machines, probably a complete rewrite of the benchmark results table would be required, perhaps noting the machine specs as well.
This is just a thought and is open for discussion.
The text was updated successfully, but these errors were encountered:
It's a great idea and I have thought of automating the calculation of each implementation's runtime. I will be manually updating the README later this week.
We have come to a point though where many of these implementations are no longer apples to apples comparisons. They vary in some subtle and not so subtle ways:
Holding contents in memory rather than streaming in lines
Using regex or using substring
Handling ASCII or Unicode
Others.
This repo is becoming more a source of idiomatic implementations rather than a fair speed comparison. I'll be including this information in the README.
Your idea is still very valid though, we could still use an automatic way of running and tracking benchmarks across languages. It could spur more community involvement.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It would be nice to have the "Results" table in the README kept up to date. For instance, a Rust implementation was recently added (#14), and there's a pull request to improve said implementation (#5).
Obviously, this could be a CI task, but maybe the simpler thing to do is update the README in any pull request which changes/adds implementation(s)? For consistency across machines, probably a complete rewrite of the benchmark results table would be required, perhaps noting the machine specs as well.
This is just a thought and is open for discussion.
The text was updated successfully, but these errors were encountered: