Restored 3-input constructor for SessionWrapper (to preserve mobile b… #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OrangeAndGreen it might be better to lean on the consistency side, why not pass the window width on mobile too instead of setting it to |
shubham1g5
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Added an issue to pass window width - dimagi/commcare-android#2878 as a separate item, and going to merge this to get the master builds passing. In general, we should be treating the master build failures as a critical event and should be fixing those promptly as it affects other external and internal devs working on the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restored 3-input constructor for SessionWrapper (to preserve mobile build).
This change is to fix the mobile build, after a recent commit changed a constructor for SessionWrapper to take a new field called windowWidth. This field is only stored by the wrapper for later external access, and is never used by the mobile code. So I added a new 3-input constructor that then passes null for the windowWidth.