Fixes for Date Range Widget for Case Search screen #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
shubham1g5
commented
Jul 8, 2024
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| public class DateRangeUtils { |
There was a problem hiding this comment.
avazirna
approved these changes
Jul 31, 2024
|
@shubham1g5 I believe these are also good to merge but it was as a draft, any concerns? |
|
no concerns |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Fixes date range widget
https://dimagi.atlassian.net/browse/QA-6604
Technical Summary
Date Range widget on mobile had a few bugs related to default value handling.It was assuming that the default values will be set in the form
__range__startDate_endDatewhile we set those as human readable dates for ex -concat(date(today()-60) , ' to ' , date(today())). This error doesn't surface for FP as this date conversion is done by JS code on Web Apps which is not great as well since it leads to mobile and Web Apps having separate implementation for the same functionality.Safety Assurance
Safety story
Test for date conversion included in PR, will go through QA testing
Special deploy instructions
Rollback instructions
Review
Duplicate PR
Automatically duplicate this PR as defined in contributing.md.
cross-request: dimagi/commcare-android#2779