Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent menu changes #1413

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Persistent menu changes #1413

merged 2 commits into from
Aug 8, 2024

Conversation

shubham1g5
Copy link
Contributor

Technical Summary

API Changes required for dimagi/formplayer#1594

Safety Assurance

Same as dimagi/formplayer#1594

QA Plan

No

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

@shubham1g5 shubham1g5 mentioned this pull request Jun 28, 2024
Merged
3 tasks
@shubham1g5
Copy link
Contributor Author

duplicate this PR

@github-actions github-actions bot mentioned this pull request Aug 8, 2024
Merged
@shubham1g5 shubham1g5 merged commit 0e14c0f into formplayer Aug 8, 2024
2 checks passed
@shubham1g5 shubham1g5 deleted the persistentMenuChanges branch August 8, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinRiese MartinRiese MartinRiese approved these changes

@snopoke snopoke Awaiting requested review from snopoke

@Robert-Costello Robert-Costello Awaiting requested review from Robert-Costello

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham1g5 @MartinRiese