Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android 13 update #1329

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Android 13 update #1329

merged 1 commit into from
Sep 21, 2023

Conversation

avazirna
Copy link
Contributor

@avazirna avazirna commented Sep 12, 2023 •
edited
Loading

Product Description

This PR implements changes required to support Android 13. The relevancy here are ICU updates that made handling data symbols more locale-stricter.

@avazirna avazirna mentioned this pull request Sep 12, 2023
Merged
1 task
@avazirna avazirna changed the title Set locale to date format Android 13 update Sep 12, 2023
@avazirna avazirna self-assigned this Sep 21, 2023
@avazirna avazirna requested a review from shubham1g5 September 21, 2023 10:46
@avazirna
Copy link
Contributor Author

@shubham1g5 I forgot to request your review on this PR.

@shubham1g5
Copy link
Contributor

Is this not a mandatory API change ? curious why is not it causing android build to fail on master without this merged ?

@avazirna
Copy link
Contributor Author

Is this not a mandatory API change ? curious why is not it causing android build to fail on master without this merged ?

It is. It can cause errors depending on the device configuration, for instance I have my device language set to en_ZA (English - South Africa) and now the abbreviation of September appears as Sept and not Sep (like in the English language), which causes the parser here to fail. But in this case, this is only relevant for date months in the MMM form.

@shubham1g5
Copy link
Contributor

I understand the motivation, though how is it related to Android 13 ?

@avazirna
Copy link
Contributor Author

I understand the motivation, though how is it related to Android 13 ?

My take is that this is caused by the ICU changes brought by Android 13.

@avazirna avazirna merged commit fe9fea0 into master Sep 21, 2023
2 checks passed
@avazirna
Copy link
Contributor Author

duplicate this PR 5db37b9

@shubham1g5
Copy link
Contributor

duplicate this PR 5db37b9

@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Merged
@avazirna avazirna added this to the 2.54 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham1g5 shubham1g5 shubham1g5 approved these changes

Assignees

@avazirna avazirna

Labels
None yet
Projects
None yet
Milestone
2.54
Development

Successfully merging this pull request may close these issues.
2 participants
@avazirna @shubham1g5