Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds alignment to Detail Style #1299

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Adds alignment to Detail Style #1299

merged 2 commits into from
Jun 20, 2023

Conversation

shubham1g5
Copy link
Contributor

Technical Summary

https://dimagi-dev.atlassian.net/browse/USH-3327

Some of the style fields were not getting saved properly as we were not saving them to serialised stream.

Special deploy instructions

This PR breaks app DB serialisation and will result in Web Apps making a fresh app ccz request. This has been fine in past for us and hence I don't think any special considerations should be necessary at this point.

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

@shubham1g5 shubham1g5 merged commit fd9c566 into formplayer Jun 20, 2023
@shubham1g5 shubham1g5 deleted the addsAlignmentToResp branch June 20, 2023 14:02
@shubham1g5 shubham1g5 restored the addsAlignmentToResp branch October 16, 2023 19:06
@shubham1g5
Copy link
Contributor Author

duplicate this PR b62f942

@shubham1g5
Copy link
Contributor Author

duplicate this PR b62f942 93fad33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants