Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding native AWS Types #1963

Open
hrferdowsi opened this issue Oct 25, 2023 · 1 comment
Open

Adding native AWS Types #1963

hrferdowsi opened this issue Oct 25, 2023 · 1 comment

Comments

@hrferdowsi
Copy link

hrferdowsi commented Oct 25, 2023

Is your feature request related to a problem? Please describe.

graphql-eslint dosn't support AWS supported scalars and return Unknown type error. The main supported AWS scalars for AppSync are :
AWSDate, AWSDateTime, AWSEmail, AWSIPAddress, AWSJSON, AWSPhone, AWSTime, AWSTimestamp, AWSURL

it currently breaking the pipelines with this error:

0:0 error Parsing error: [graphql-eslint] Error while loading schema: Unknown type "AWSJSON".

Describe the solution you'd like

add these types as accepted scalar types:
AWSDate, AWSDateTime, AWSEmail, AWSIPAddress, AWSJSON, AWSPhone, AWSTime, AWSTimestamp, AWSURL

Describe alternatives you've considered

Atleast skip checking these types to stop pipelines from failing

@dimaMachina
Copy link
Owner

dimaMachina commented Oct 25, 2023

graphql-eslint dosn't support AWS supported scalars and return Unknown type error.

normal behaviour graphql-eslint takes input schema, and builds it, if some type is missing how he should know it?

Do you have any ideas on how to include them for AWS projects? include by default is not a good idea since the user can have their own scalar AWSEmail, maybe via some option in parserOptions or graphql-config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants