Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resizing the window several times triggers the layout emergency brake #300

Closed
rodarima opened this issue Nov 13, 2024 · 1 comment · Fixed by #301
Closed

Resizing the window several times triggers the layout emergency brake #300

rodarima opened this issue Nov 13, 2024 · 1 comment · Fixed by #301
Labels
bug Something isn't working layout Layouting
Milestone
Release 3.2.0

Comments

@rodarima
Copy link
Member

We should reset the counter of the layout loop if the window is being resized, otherwise it will lock and no more layout updates will happen.

See #236
@rodarima rodarima added bug Something isn't working layout Layouting labels Nov 13, 2024
@rodarima rodarima added this to the Release 3.2.0 milestone Nov 13, 2024
@rodarima
Copy link
Member Author

rodarima commented Nov 13, 2024 •
edited
Loading

There are multiple Layout instances in a single tab and each is currently using its own resizeCounter. This is used for ComplexButtonResource. We may want to use it only in the top level one, otherwise each sub-layout may break at different times.

@rodarima rodarima mentioned this issue Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working layout Layouting
Projects
None yet
Milestone
Release 3.2.0
Development

Successfully merging a pull request may close this issue.

Reset resize counter when viewport changes size dillo-browser/dillo
1 participant
@rodarima