-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for droplet autoscale pool #1280
Conversation
Hey Aditya, could you please include an API documentation link in the description if you have one. Thanks 🐬 |
@loosla the openapi spec is still in review: here's the open draft |
4ab9548
to
5d2f4f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great! 🙌
There are some complications we need to consider around images though. (See discussion in-line.)
It would also be great to get some documentation (see /docs
directory for examples.).
digitalocean/dropletautoscale/resource_droplet_autoscale_test.go
Outdated
Show resolved
Hide resolved
digitalocean/dropletautoscale/resource_droplet_autoscale_test.go
Outdated
Show resolved
Hide resolved
655db63
to
27ab4b0
Compare
@andrewsomething I've added to the docs and a test sweeper function for cleanup as well ☑️ ready for another round of 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Good catch with the sweeper!
- [x] vendor latest godo