Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for droplet autoscale pool #1280

Merged
merged 9 commits into from
Dec 9, 2024

Conversation

asaha2
Copy link
Contributor

@asaha2 asaha2 commented Nov 27, 2024

- [x] vendor latest godo

  • implement datasource methods
  • implement resource methods
  • add unit tests

@loosla
Copy link
Contributor

loosla commented Nov 27, 2024

Hey Aditya, could you please include an API documentation link in the description if you have one. Thanks 🐬

@asaha2
Copy link
Contributor Author

asaha2 commented Nov 27, 2024

@loosla the openapi spec is still in review: here's the open draft
digitalocean/openapi#949

@asaha2 asaha2 force-pushed the asaha/AUTOSCALE-79 branch from 4ab9548 to 5d2f4f5 Compare November 29, 2024 17:02
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great! 🙌

There are some complications we need to consider around images though. (See discussion in-line.)

It would also be great to get some documentation (see /docs directory for examples.).

@asaha2
Copy link
Contributor Author

asaha2 commented Dec 5, 2024

@andrewsomething I've added to the docs and a test sweeper function for cleanup as well ☑️ ready for another round of 👀

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Good catch with the sweeper!

@andrewsomething andrewsomething self-assigned this Dec 6, 2024
@andrewsomething andrewsomething merged commit c0ea0d4 into digitalocean:main Dec 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants