Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for features in digitalocean_app spec #1033

Closed
corygibbons opened this issue Sep 20, 2023 · 3 comments
Closed

Support for features in digitalocean_app spec #1033

corygibbons opened this issue Sep 20, 2023 · 3 comments

Comments

@corygibbons
Copy link

corygibbons commented Sep 20, 2023

Is your feature request related to a problem? Please describe.

Trying to update the buildpack version to support node 18 but can't seem to configure it in the resource.

Describe the solution you'd like

Doesn't particularly matter but something similar to env vars could work:

resource "digitalocean_app" "foo" {
  spec {
    feature {
      key    = "buildpack-stack"
      value  = "ubuntu-22"
    }
  }
}

or

resource "digitalocean_app" "foo" {
  spec {
    feature {
      value = "buildpack-stack=ubuntu-22"
    }
  }
}

https://docs.digitalocean.com/products/app-platform/reference/app-spec

@danaelhe
Copy link
Member

Thank you for the suggestion, this should be easy to implement since godo does support features here. We've created a ticket in our backlog to get to it as soon as we can. I've also added the "hacktoberfest" label incase someone wanted to take it on for hacktoberfest!

@T-jegou
Copy link
Contributor

T-jegou commented Nov 3, 2023

Hello @danaelhe , I tried to fix this issue, can you take a look? Thanks

@corygibbons
Copy link
Author

@T-jegou thanks for adding a PR for this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants