-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace artemis with graphql_codegen #1788
base: upgrade-flutter-to-3.22
Are you sure you want to change the base?
Conversation
2a15bb2
to
3b33aeb
Compare
ddddae8
to
f99a19e
Compare
3b33aeb
to
2370266
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.06 (9.33 -> 9.27)
- Declining Code Health: 1 findings(s) 🚩
f99a19e
to
4aabc7e
Compare
2370266
to
d3fc56f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.06 (9.33 -> 9.27)
- Declining Code Health: 1 findings(s) 🚩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on android, did not find any problems
Short description
Replace the discontinued artemis package with graphql_codegen.
Proposed changes
I went with graphql_codegen, as I believe using
ferry
would require much more changes, and has an (imo) worse API.Side effects
None
Testing
Smoke test interactions with the server.
Resolved issues
Fixes: #1352