Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace artemis with graphql_codegen #1788

Open
wants to merge 1 commit into
base: upgrade-flutter-to-3.22
Choose a base branch
from

Conversation

michael-markl
Copy link
Member

@michael-markl michael-markl commented Nov 19, 2024

Short description

Replace the discontinued artemis package with graphql_codegen.

Proposed changes

I went with graphql_codegen, as I believe using ferry would require much more changes, and has an (imo) worse API.

Side effects

None

Testing

Smoke test interactions with the server.

Resolved issues

Fixes: #1352

@michael-markl michael-markl force-pushed the upgrade-frontend-graphql branch 3 times, most recently from 2a15bb2 to 3b33aeb Compare November 19, 2024 12:31
@michael-markl michael-markl linked an issue Nov 19, 2024 that may be closed by this pull request
@michael-markl michael-markl marked this pull request as ready for review November 20, 2024 12:38
@michael-markl michael-markl force-pushed the upgrade-flutter-to-3.22 branch from ddddae8 to f99a19e Compare November 20, 2024 16:12
@michael-markl michael-markl force-pushed the upgrade-frontend-graphql branch from 3b33aeb to 2370266 Compare November 20, 2024 16:14
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.06 (9.33 -> 9.27)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

@michael-markl michael-markl force-pushed the upgrade-flutter-to-3.22 branch from f99a19e to 4aabc7e Compare November 20, 2024 16:21
@michael-markl michael-markl force-pushed the upgrade-frontend-graphql branch from 2370266 to d3fc56f Compare November 20, 2024 16:22
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.06 (9.33 -> 9.27)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on android, did not find any problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace artemis
2 participants