Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role and option to create api tokens for verein 360 #1624

Closed
f1sh1918 opened this issue Sep 9, 2024 · 5 comments · Fixed by #1794
Closed

Add role and option to create api tokens for verein 360 #1624

f1sh1918 opened this issue Sep 9, 2024 · 5 comments · Fixed by #1794
Assignees
Labels
Milestone

Comments

@f1sh1918
Copy link
Contributor

f1sh1918 commented Sep 9, 2024

Is your feature request related to a problem? Please describe.
If the mutation to add applications is called with the "isAlreadyVerified" flag it needs to be protected with the api token. These api tokens should be created by a user with a specific role.

Describe the solution you'd like

  • create a separate role "Verein 360" that can create api tokens
  • check if the api token has the correct access rights (is role Verein360 and project eak)
@f1sh1918 f1sh1918 added the Task label Sep 9, 2024
@f1sh1918 f1sh1918 added this to the Verein360 milestone Sep 9, 2024
@f1sh1918
Copy link
Contributor Author

f1sh1918 commented Sep 9, 2024

@ztefanie not sure if we also have to add the possibility to create a user with this role via administration gui or it is sufficient to create it via runConfig and backend command, since we probably will only need one. Please check if there is anything to add in this ticket :)

@ztefanie
Copy link
Member

I think this user should also be able to be created via administration ui, it is not really effort for us to do this.

But in general I think it would be nice, if we move to a clean RBAC structure, i created a ticket for this here: #1626
we can discuss this at a grooming.

@f1sh1918 f1sh1918 added the blocked Task or user story can not be continued at the moment label Nov 18, 2024
@ztefanie ztefanie changed the title Verein360 application data endpoint protection Add role and option to create api tokens for verein 360 Nov 20, 2024
@ztefanie ztefanie removed the blocked Task or user story can not be continued at the moment label Nov 20, 2024
@ztefanie ztefanie moved this to Next Up in team-app Nov 20, 2024
@ztefanie ztefanie self-assigned this Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Next Up to Done in team-app Dec 4, 2024
@seluianova
Copy link
Contributor

@f1sh1918 @ztefanie just for my better understanding, could you please clarify why we decided to add a new role for that?
why not allow tokens to be created by project admin, for example?

@ztefanie
Copy link
Member

ztefanie commented Dec 4, 2024

@f1sh1918 @ztefanie just for my better understanding, could you please clarify why we decided to add a new role for that? why not allow tokens to be created by project admin, for example?

Because then the project admin would need to somehow send verein360 the api token and this will likely happen in a unsecure way, e.g. via email. But we want to ensure our tokens stay secret. But on the other hand giving an external organization like verein360 the full admin rights to the project also brings risks and is not what we want. Therefore we introduced the new role.

@seluianova
Copy link
Contributor

@ztefanie right, makes sense, thanks for the reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants