Add credentialStatus to VCs in status tests & fix assertions #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 87.42% 88.77% +1.35%
==========================================
Files 4 4
Lines 811 811
==========================================
+ Hits 709 720 +11
+ Misses 102 91 -11 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
aljones15
force-pushed
the
check-credential-status-verification-tests
branch
from
4f4a771 to
b1398f6
Compare
aljones15
changed the title
JSAssassin
reviewed
Dec 6, 2023
Co-authored-by: Tashi D. Gyeltshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes 2 tests so they contain
credentialStatusand then adds one test for a VC with no status.