Add test to ensure issuanceDate is added to VC 1.1 VCs. #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSAssassin
approved these changes
Dec 6, 2023
test/10-verify.spec.js
Outdated
Comment on lines
197
to
198
| const jsonDate = now.toJSON(); | ||
| const expectedIssuanceDate = `${jsonDate.slice(0, jsonDate.length - 5)}Z`; |
There was a problem hiding this comment.
Just another way of doing it, but one less line.
Suggested change
| const jsonDate = now.toJSON(); | |
| const expectedIssuanceDate = `${jsonDate.slice(0, jsonDate.length - 5)}Z`; | |
| const expectedIssuanceDate = now.toISOString().slice(0, -5) + 'Z'; |
There was a problem hiding this comment.
I like the now.toISOString() approach better, but we should keep the string interpolation in place.
There was a problem hiding this comment.
@JSAssassin @BigBlueHat I like the toISOString method more too, I was copying the way the issuanceDate is set inside of index.js should I update that to? test updated here: b34181d
p.s. I could update the one in index.js to use toISOString.slice(0, -5) in the validUntil PR as that already contains breaking changes to the DateRegexp.
BigBlueHat
approved these changes
Dec 6, 2023
…vcs in test titles. Co-authored-by: Tashi D. Gyeltshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.