Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo, remove unncessary functions, and add example for update_config_workflow #268

Open
yucongalicechen opened this issue Dec 22, 2024 · 0 comments · May be fixed by #270
Open

fix typo, remove unncessary functions, and add example for update_config_workflow #268

yucongalicechen opened this issue Dec 22, 2024 · 0 comments · May be fixed by #270
Milestone

Comments

@yucongalicechen
Copy link
Contributor

          Thanks for the excellent review @yucongalicechen .  Please could you make a PR to fix those things?  Let's also double check there are no private functions that are not use, or public functions that we want to make private.

If @bobleesj finds anything else we can put that into the same PR.

I also wanted to add into the docs what happens in the update config workflow when it is triggered, so reproduce what the user would see and give an example of how they would respond. It would be great for me if that could be in the same PR?

Originally posted by @sbillinge in #264 (comment)

@yucongalicechen yucongalicechen added this to the 3.6.0 release milestone Dec 22, 2024
@yucongalicechen yucongalicechen linked a pull request Dec 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant