Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we should start thinking about how to change the system so that we could run it once every hour, or less #17

Open
mimoo opened this issue Feb 6, 2021 · 2 comments

Comments

@mimoo
Copy link
Contributor

mimoo commented Feb 6, 2021

Why run it once every hour? Or less? instead of once a day

  • We should know as soon as possible when cargo-audit has new RUSTSEC
  • When people end up updating a dependency, it should get removed from the list

What should be changed?

  • The summary since last analysis (the first yellow div on the page) should instead show the summary of the day, or of the week (maybe this could be dynamically changed).
  • we should avoid re-running the whole thing. We should take the last analysis, remove anything that's not there anymore, and only re-run things if the version of a dependency has changed or if it has a new version

How much work?

I think a lot needs to be re-thought if we want to optimize that. But is it necessary? An analysis doesn't take that much time to complete (maybe 5min max?) So I don't think we need to optimize it that much. Sure we do a bunch of requests to github and crates.io, but they must receive much much more request from people's IDE alone.

@mimoo
Copy link
Contributor Author

mimoo commented Feb 6, 2021

Another way to do this: Only compare the current analysis with the last analysis from yesterday, and then delete any analysis from today before adding the current analysis.

So for example, imagine there are 2 analysis:

  • yesterday analysis
  • today analysis done an hour ago

when performing a new analysis, compare it with the one from yesterday, then delete the one from today, then store yours

@mimoo
Copy link
Contributor Author

mimoo commented Mar 9, 2021

I'd like some user feedback on that actually. (cc @xvschneider @jnaulty @AnomalRoil)

Currently we manually create analysis by clicking on the refresh button, and it'll create a summary between the new analysis and the last one. This works well if you:

  • run your own personal whackadep
  • are willing to manually trigger and wait for an analysis when you need the tool

as soon as we:

  • have multiple users
  • run the analysis periodically (e.g. every 30min)

we run into issues.

So my question is, what should we do? What's best for the user?

As a user, I want to know what has changed since the last time I looked around, or maybe if that's too old, at least since like last week or yesterday. But everyone might have different requirements... so what does this mean, do we want to create a default "this is the summary change since yesterday" with the possibility of changing this to a week, a month, etc.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant