Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the auto-generated BlockchainRESTClient works, deprecate the hand-rolled one; if it doesn't, remove it #94

Open
gthoma17 opened this issue Dec 7, 2021 · 2 comments
Open

If the auto-generated BlockchainRESTClient works, deprecate the hand-rolled one; if it doesn't, remove it #94

gthoma17 opened this issue Dec 7, 2021 · 2 comments

Comments

@gthoma17
Copy link
Contributor

gthoma17 commented Dec 7, 2021 •
edited
Loading

If the auto-generated client works, make sure you also replace the hand-rolled types used by the REST client (ie BlockchainAccountModule)
@gthoma17
Copy link
Contributor Author

gthoma17 commented Dec 7, 2021 •
edited
Loading

Update to: deprecate the autogenerated client

@mkollasch-vmware mkollasch-vmware changed the title If the auto-generated BlockchainRESTClient works, deprecate the hand-rolled one, if it doesn't remove it If the auto-generated BlockchainRESTClient works, deprecate the hand-rolled one; if it doesn't, remove it Dec 8, 2021
@gthoma17
Copy link
Contributor Author

Demo: https://github.com/diem/explorer/pull/111/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gthoma17