Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diem ID Payment in Miniwallet with E2E Test #309

Merged
merged 5 commits into from
Jun 28, 2021
Merged

Diem ID Payment in Miniwallet with E2E Test #309

merged 5 commits into from
Jun 28, 2021

Conversation

sunmilee
Copy link
Contributor

@sunmilee sunmilee commented Jun 21, 2021 •
edited
Loading

This PR adds functionality to send and receive payments using DiemID as the account identifier, with a full E2E test. Things to note:

  • Created a new ReferenceID storage model to check for duplicate reference ID
  • "payee" in txn can now be either diem ID or bech 32 address
  • Internal transaction with diem ID is not handled

Continuation from: #306

@sunmilee sunmilee changed the title Add e2e test Diem ID Payment in Miniwallet with E2E Test Jun 22, 2021
@sunmilee sunmilee requested a review from xli June 22, 2021 02:19
@sunmilee sunmilee mentioned this pull request Jun 22, 2021
Open
24 tasks
@sunmilee sunmilee linked an issue Jun 22, 2021 that may be closed by this pull request
Diem ID #291
Open
24 tasks
xli
xli reviewed Jun 22, 2021
View reviewed changes
src/diem/identifier/diem_id.py Show resolved Hide resolved
src/diem/identifier/diem_id.py Outdated Show resolved Hide resolved
src/diem/identifier/diem_id.py Show resolved Hide resolved
src/diem/identifier/diem_id.py Show resolved Hide resolved
src/diem/testing/miniwallet/app/app.py Show resolved Hide resolved
src/diem/testing/miniwallet/app/app.py Outdated Show resolved Hide resolved
src/diem/testing/miniwallet/app/offchain_api_v2.py Outdated Show resolved Hide resolved
src/diem/testing/miniwallet/app/offchain_api_v2.py Outdated Show resolved Hide resolved
src/diem/testing/miniwallet/app/offchain_api_v2.py Outdated Show resolved Hide resolved
src/diem/testing/miniwallet/app/offchain_api_v2.py Outdated Show resolved Hide resolved
@sunmilee sunmilee requested a review from xli June 24, 2021 08:35
xli
xli reviewed Jun 24, 2021
View reviewed changes
src/diem/testing/miniwallet/app/app.py Outdated Show resolved Hide resolved
src/diem/testing/miniwallet/app/app.py Outdated Show resolved Hide resolved
src/diem/testing/miniwallet/app/app.py Outdated Show resolved Hide resolved
src/diem/testing/miniwallet/app/app.py Outdated Show resolved Hide resolved
src/diem/testing/miniwallet/app/app.py Show resolved Hide resolved
@sunmilee sunmilee requested a review from xli June 28, 2021 19:18
xli
xli approved these changes Jun 28, 2021
View reviewed changes
src/diem/testing/miniwallet/app/offchain_api_v2.py Outdated Show resolved Hide resolved
src/diem/testing/miniwallet/app/offchain_api_v2.py Show resolved Hide resolved
src/diem/testing/miniwallet/app/app.py Outdated Show resolved Hide resolved
@sunmilee sunmilee merged commit 6ff2f1f into diem:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xli xli xli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diem ID
2 participants
@sunmilee @xli