Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing Wrong Input When Type #142

Open
MohitBansal321 opened this issue Nov 5, 2023 · 7 comments
Open

Showing Wrong Input When Type #142

MohitBansal321 opened this issue Nov 5, 2023 · 7 comments

Comments

@MohitBansal321
Copy link
Contributor

The Problem

When I play the Kaoes game and I have to write -T
In the input section, the hyphen is displayed in the wrong format

Approach

We have to remove the underline of character when we type anything

Screenshot

image

Source

https://didoesdigital.com/typey-type/games/KAOES

I will try it if you think this change is significant

@didoesdigital
Copy link
Owner

Thanks for this. It's kind of weird seeing an hyphen with an underline!

This textarea is currently using the same styling as other textareas. In lessons the underline is useful for showing where spaces have been typed, but this textarea ignores spaces so it doesn't need the underline. So yeah, you can try remove the underline from here but keep it in lessons.

@MohitBansal321
Copy link
Contributor Author

image
Hey @didoesdigital
Can you help me when I pull the latest code it shows some changes in typed-type-data/

@didoesdigital
Copy link
Owner

You can run the git submodule update command: https://github.com/didoesdigital/typey-type#updates

@MohitBansal321
Copy link
Contributor Author

MohitBansal321 commented Dec 10, 2023

Thanks for your patience. I was busy with my internship.
Now I can work on it
Did you add new packages?
I am getting error to run it locally

@didoesdigital
Copy link
Owner

@MohitBansal321 Yes, both "chromatic" and "@types/clipboard" packages were updated recently. You may need to git pull, git submodule update, and run yarn install to install the latest packages before continuing development with yarn start

@MohitBansal321
Copy link
Contributor Author

There are any platform from which we can communicate for this project easily (discord,slack etc)

@didoesdigital
Copy link
Owner

There's the Plover Discord #education-dev channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants