Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Words trained with spaces before words, ignore spaces and spaces after words are counted separately #130

Open
Monniasza opened this issue Aug 12, 2023 · 1 comment

Comments

@Monniasza
Copy link

Monniasza commented Aug 12, 2023

Requirements:

  • The Typey Type starts with no progress
  • Words are grouped into sets A, B, and C
  • All three sets of words (A, B, and C) are disjoint

How to reproduce:

  1. Train a set A of words with spaces ignored.
  2. Train a set B of words with spaces before words.
  3. Train a set C of words with spaces after words.
  4. Revise with spaces ignored.

Workaround:
Revise with spaces before words with new words, but this does not count towards seen words goal

Expected behavior:
Revising shows words from all sets

Actual behavior:
Revising shows only words from the set A

@Monniasza Monniasza changed the title [BUG] Words trained with spaces before word,ignore spaces and spaces after word are counted separately [BUG] Words trained with spaces before words, ignore spaces and spaces after words are counted separately Aug 12, 2023
@didoesdigital
Copy link
Owner

didoesdigital commented Aug 20, 2023

Thanks for letting me know this behaviour doesn't match your expectations and writing up the bug.

Historically I've supported this behaviour so that people can intentionally practice different spacing settings if they decide to switch between them.

For people that find this unhelpful, they can reformat their previous progress to match their new spacing setting on the progress page

Vocabulary progress. If you’ve changed your spacing settings, you can download a reformatted “progress file” to match your new setting. After downloading it, if you're happy it looks good you can load it back into Typey Type. Then visit each lesson to update lesson progress. Your current spacing setting is: Space before output. [Download reformatted progress file](blob:https://didoesdigital.com/8300b543-a273-487f-af1d-f5d8d7fea22f)

Can you think of some ways to make this situation better while supporting different preferences? Maybe we could provide a link to the reformatting option next to the spacing setting? Or mention it the first time someone changes the spacing setting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants