-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grammar precedence doesn't seem to work correctly on Kaldi #812
Comments
Good catch. The behavior working correctly with DNS is related to something within |
Yeah, different engines handle ambiguous grammars differently. The current recommended way to handle this in Kaldi is to set a weight on one of them, to determine which should take precedence. Technically, "priority" and "weight" are slightly different concepts, but in the interest of simplicity, I think weight suffices. Any weight set will be simply ignored by engines that don't support it. |
I also just noticed that this is actually not consistent. So i guess there is some amount of randomness as well? It also rarely will choose the Legion one but not never. |
Awesome. Just added weight=1000 and it just seems to work perfectly! Thanks @daanzu |
FWIW, I usually just add a weight=10 to my "special mode" grammars, but I haven't done much testing of it. |
As you find other issues like this don't hesitate to open up a pull request as setting weights shouldn't affect other engines. |
Describe the bug
Two bugs I believe caused by the same thing.
To Reproduce
Steps to reproduce the behavior (be sure to include the exact command phrase you are using):
Caster runs the Navigation
squat
command not the Douglas one.Expected behavior
Douglas records that you have squatted.
Comments
If I recall correctly, Caster doesn't currently have a formal process for dealing with conflicts between rules. However, when using Dragon Naturallyspeaking, these sorts of "knockout" behaviours just seemed to work correctly. As in, Dragon/Natlink/Caster correctly knew to use the mouse grammar and not the navigation grammar. Any help from @synkarius would be very welcome!
System:
The text was updated successfully, but these errors were encountered: