Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using element.find without jQuery doesn't work correctly #75

Open
schmuli opened this issue Oct 27, 2016 · 0 comments
Open

Using element.find without jQuery doesn't work correctly #75

schmuli opened this issue Oct 27, 2016 · 0 comments

Comments

@schmuli
Copy link

schmuli commented Oct 27, 2016

This issue was introduced by the changes in PR #69 on line 156.

The find method is used to locate the span for the custom click action. However, as mentioned in the AngularJS documentation, the find method in jqLite is limited to only tag names, and therefore this doesn't work anymore for apps that don't load the full jQuery.

A way to fix this would be to use querySelector:

angular.element(element[0].querySelector('span.angular-ellipsis-append'))
    .bind(...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant