You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've selected devilution.DefaultClass::CheckInvPaste(int, int, int) for refactoring, which is a unit of 362 lines of code and 135 branch points. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Simple Units of Code guideline rating! 👍
Here's the gist of this guideline:
Definition 📖
Limit the number of branch points (if, for, while, etc.) per unit to 4.
Why❓
Keeping the number of branch points low makes units easier to modify and test.
How 🔧
Split complex units with a high number of branch points into smaller and simpler ones. This one in particular has a big switch that could probably be split out in to sub-functions.
I've selected devilution.DefaultClass::CheckInvPaste(int, int, int) for refactoring, which is a unit of 362 lines of code and 135 branch points. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Simple Units of Code guideline rating! 👍
Here's the gist of this guideline:
Limit the number of branch points (if, for, while, etc.) per unit to 4.
Keeping the number of branch points low makes units easier to modify and test.
Split complex units with a high number of branch points into smaller and simpler ones. This one in particular has a big switch that could probably be split out in to sub-functions.
You can find more info about this guideline in Building Maintainable Software. 📖
Good luck and happy coding! ✨ 💯
The text was updated successfully, but these errors were encountered: