Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue and PR management in order to create a new release #248

Open
johnmanko opened this issue Dec 15, 2021 · 9 comments
Open

Issue and PR management in order to create a new release #248

johnmanko opened this issue Dec 15, 2021 · 9 comments
Labels
feedback Pending feedback
Milestone

Comments

@johnmanko
Copy link
Collaborator

johnmanko commented Dec 15, 2021

Just looking to get @dhorions's attention here. We really need some changes on this project. :)

PR #247 (fix: #233, #236, #237, #239, #241, #246) addresses the following issues and PRs, and should be merged:

PR #224 (Bugfix216) should be merged, as it fixes #216 (> is replaced with > in the Inner Table with boxable)

PR #234 ( Issue #120: Add support for setting hyperlink URL on a Cell) fixes issue #120

PR #106 (Add license information to the pom.xml) and Issue #231 (Boxable jar may not be Apache 2 licensed) need reconciliation, as they both deal with Apache 2.0 licensing.

PR #151 (Table class overhauled, main package cleaned up.) looks like a great candidate.

@johnmanko
Copy link
Collaborator Author

@dhorions Would you like to transfer this project to me so I can start merging pull requests? Also, I'd like to do a maven release.

@dhorions
Copy link
Owner

dhorions commented Apr 22, 2022

Hello @johnmanko,

You are right , I haven't been giving this project the attention it deserves . Can we talk about this on a call? What works for you and how can I reach you best?

@johnmanko
Copy link
Collaborator Author

@dhorions I don't see a way to communicate privately through Github, so I guess I'll have to create a temporary email address to exchange numbers. I'll do that this weekend and update this issue with that info.

Thanks for getting back to me.

@dhorions
Copy link
Owner

dhorions commented Apr 22, 2022

You can also send me a pm on twitter https://twitter.com/indiedries @johnmanko

@johnmanko
Copy link
Collaborator Author

@dhorions I'll have to create a twitter account. haha.

@dhorions
Copy link
Owner

dhorions commented Apr 26, 2022

@johnmanko email me at ****

@johnmanko
Copy link
Collaborator Author

@dhorions email sent.

@johnmanko
Copy link
Collaborator Author

PR #247 fixed with 943e453

@johnmanko
Copy link
Collaborator Author

I'd also like to review #98

The more dependencies that can be removed, the better. And perhaps changing pdfbox/etc to provided will provide more flexibility to users.

@johnmanko johnmanko added this to the 1.7.1 milestone Jun 15, 2022
@johnmanko johnmanko added the feedback Pending feedback label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Pending feedback
Projects
None yet
Development

No branches or pull requests

2 participants