From 84930777459b1c42753414868733810eff55edf1 Mon Sep 17 00:00:00 2001 From: HendrikThePendric Date: Wed, 13 Sep 2023 09:55:41 +0200 Subject: [PATCH] fix: default visualizationHasTimeDimension to true Without this default value the changes in this PR would actually constitute to a breaking change, at least for the line-listing-app: if the `visualizationHasTimeDimension` prop is not provided and the `type` equals `eventVisualization`, the helptext would be rendered. By defaulting to `true` we avoid this, only explicitly setting `visualizationHasTimeDimension` to `false` will cause the help text to show. I think this is mainly a theoretical issue, because the line-listing-app will always set the prop. But who knows: there could be a 3rd party app out there using the analytics library which would break because of this. --- .../Interpretations/InterpretationsUnit/InterpretationsUnit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/Interpretations/InterpretationsUnit/InterpretationsUnit.js b/src/components/Interpretations/InterpretationsUnit/InterpretationsUnit.js index 17359ea4f..8acb12d7b 100644 --- a/src/components/Interpretations/InterpretationsUnit/InterpretationsUnit.js +++ b/src/components/Interpretations/InterpretationsUnit/InterpretationsUnit.js @@ -187,6 +187,7 @@ InterpretationsUnit.displayName = 'InterpretationsUnit' InterpretationsUnit.defaultProps = { onInterpretationClick: Function.prototype, + visualizationHasTimeDimension: true, } InterpretationsUnit.propTypes = {