From 384bb5ae183ea8c6a2c35440caf2a4d25aaf959b Mon Sep 17 00:00:00 2001
From: Daniel Smith <dgasmith@icloud.com>
Date: Thu, 26 Sep 2024 16:18:06 -0400
Subject: [PATCH] CI Fix (#240)

* Tweaks CI to new bash defaults

* Updates day which the 3.4 was released

* Removes mamba-version in CI as miniconda merge mamaba

* Fixes linting as well
---
 .github/workflows/Linting.yml | 19 ++++++++-----------
 .github/workflows/Tests.yml   |  8 +++-----
 docs/changelog.md             |  2 +-
 3 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/Linting.yml b/.github/workflows/Linting.yml
index 68fca58..9d2e90b 100644
--- a/.github/workflows/Linting.yml
+++ b/.github/workflows/Linting.yml
@@ -16,6 +16,9 @@ jobs:
         environment: ["min-deps"]
 
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        shell: bash -el {0}
 
     steps:
     - uses: actions/checkout@v4
@@ -23,13 +26,11 @@ jobs:
     - uses: conda-incubator/setup-miniconda@v3
       with:
         python-version: ${{ matrix.python-version }}
-        mamba-version: "*"
         channel-priority: true
         activate-environment: test
         environment-file: devtools/conda-envs/${{ matrix.environment }}-environment.yaml
 
     - name: Environment Information
-      shell: bash -l {0}
       run: |
         conda info
         conda list
@@ -37,14 +38,10 @@ jobs:
         conda config --show
 
     - name: Install
-      shell: bash -l {0}
-      run: |
-        python -m pip install . --no-deps
+      run: python -m pip install . --no-deps
 
     - name: MyPy
-      shell: bash -l {0}
-      run: |
-        mypy opt_einsum
+      run: mypy opt_einsum
 
   ruff:
     name: Ruff
@@ -55,6 +52,9 @@ jobs:
         environment: ["min-deps"]
 
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        shell: bash -el {0}
 
     steps:
     - uses: actions/checkout@v2
@@ -62,13 +62,11 @@ jobs:
     - uses: conda-incubator/setup-miniconda@v3
       with:
         python-version: ${{ matrix.python-version }}
-        mamba-version: "*"
         channel-priority: true
         activate-environment: test
         environment-file: devtools/conda-envs/${{ matrix.environment }}-environment.yaml
 
     - name: Environment Information
-      shell: bash -l {0}
       run: |
         conda info
         conda list
@@ -76,7 +74,6 @@ jobs:
         conda config --show
 
     - name: Lint
-      shell: bash -l {0}
       run: |
         set -e
         make format-check
diff --git a/.github/workflows/Tests.yml b/.github/workflows/Tests.yml
index 60cab06..07749af 100644
--- a/.github/workflows/Tests.yml
+++ b/.github/workflows/Tests.yml
@@ -25,6 +25,9 @@ jobs:
            environment: "torch-only"
 
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        shell: bash -el {0}
 
     steps:
     - uses: actions/checkout@v4
@@ -32,13 +35,11 @@ jobs:
     - uses: conda-incubator/setup-miniconda@v3
       with:
         python-version: ${{ matrix.python-version }}
-        mamba-version: "*"
         channel-priority: true
         activate-environment: test
         environment-file: devtools/conda-envs/${{ matrix.environment }}-environment.yaml
 
     - name: Environment Information
-      shell: bash -l {0}
       run: |
         conda info
         conda list
@@ -51,17 +52,14 @@ jobs:
         python devtools/ci_scripts/check_no_numpy.py
 
     - name: Install
-      shell: bash -l {0}
       run: |
         python -m pip install . --no-deps
 
     - name: Test
-      shell: bash -l {0}
       run: |
         pytest -v --cov=opt_einsum opt_einsum/ --cov-report=xml
 
     - name: Coverage
-      shell: bash -l {0}
       run: |
         coverage report
 
diff --git a/docs/changelog.md b/docs/changelog.md
index 7887969..8d9bbc9 100644
--- a/docs/changelog.md
+++ b/docs/changelog.md
@@ -1,7 +1,7 @@
 Changelog
 =========
 
-## 3.4.0 / 2024-09-XX
+## 3.4.0 / 2024-09-26
 
 NumPy has been removed from `opt_einsum` as a dependency allowing for more flexible installs.