Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide badges as a part of jar file #712

Open
larisa1995 opened this issue Jun 24, 2024 · 2 comments
Open

Provide badges as a part of jar file #712

larisa1995 opened this issue Jun 24, 2024 · 2 comments
Labels
new feature request for supporting a new feature

Comments

@larisa1995
Copy link

Description of our problem: index-en.html has badges for serialisation and license. German law forbids us to forward the dynamic IP address to third parties [1 ,2].

Current behaviour: Badges are loaded dynamically from img.shields.io [3].

Proposed solution: Put shields to the folder of Widoco so that they are part of package.

[1] https://www.ihk.de/nordwestfalen/recht/rechtsthemen/wettbewerbsrecht/websiten-auf-google-fonts-ueberpruefen-5645256
[2] https://www.gesetze-bayern.de/Content/Document/Y-300-Z-BECKRS-B-2022-N-612?hl=true
[3] https://github.com/dgarijo/Widoco/blob/master/src/main/java/widoco/Constants.java

@dgarijo
Copy link
Owner

dgarijo commented Jun 24, 2024

Hmm, there are numerous badges that may be imported (the badge is generated dynamically). So option 3 is not easy to implement.

In the config you can add your own icons for licenses (https://github.com/dgarijo/Widoco/blob/master/doc/configurationSamples/config/config.properties).

Alternatively, Widoco could download all images and store them locally. Maybe that could be an option

@dgarijo dgarijo added the new feature request for supporting a new feature label Jun 24, 2024
@larisa1995
Copy link
Author

Alternatively, Widoco could download all images and store them locally. Maybe that could be an option

This option fits the requirements of our company! Could possibly next version have this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature request for supporting a new feature
Projects
None yet
Development

No branches or pull requests

2 participants