update compat + tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dfsp-spirit: Friendly ping if you'd be so kind as to look at this PR? |
|
Thanks for the ping, I was not aware of this. Sure, it's on my list for today! |
|
Hi @JakobAsslaender, thanks for your contribution. The new version NeuroFormats.jl v0.3.1 is now released and includes your changes. The PR at JuliaRegistries has already been merged, so the new version should become available soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I saw that the Compat of this package is a bit outdated and took the liberty to bring everything up to date. It would be great if you would merge and release this! I did some simplifying of the test code, but the functionality of the code remains unchanged.
Many thanks!