wip: bigint decoding #765
Closed
wip: bigint decoding #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
| // Always use a bigint encoding. | ||
| if (v > BigInt(0)) { | ||
| // Use a bigint encoding for large values | ||
| if (v > BigInt(Number.MAX_SAFE_INTEGER)) { | ||
| return cbor.value.tagged(2, cbor.value.bytes(fromHex(v.toString(16)))); |
There was a problem hiding this comment.
Do we need to fix the padding here to make it even length?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, attempting to encode a small BigInt value throws errors, and makes serialization difficult.
This approach encodes numbers between positive and negative
Number.MAX_SAFE_INTEGERas a Number when serializing to CBOR. However, this strategy doesn't allow them to be deserialized as BigInt. Is this a valid approach?How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: