From 310ca0a4981441fef7bdfcf6fee836d156b285e1 Mon Sep 17 00:00:00 2001 From: Hamish Peebles Date: Tue, 15 Aug 2023 15:11:10 +0100 Subject: [PATCH 1/2] fix: add `@dfinity/principal` as a peerDependency where needed --- package-lock.json | 4 ++++ packages/assets/package.json | 1 + packages/candid/package.json | 3 +++ 3 files changed, 8 insertions(+) diff --git a/package-lock.json b/package-lock.json index 4c5f59031..920b03637 100644 --- a/package-lock.json +++ b/package-lock.json @@ -19232,6 +19232,7 @@ }, "peerDependencies": { "@dfinity/agent": "^0.18.1", + "@dfinity/principal": "^0.18.1", "js-sha256": "0.9.0" } }, @@ -19512,6 +19513,9 @@ "typedoc": "^0.22.11", "typescript": "^4.7.4", "whatwg-fetch": "^3.0.0" + }, + "peerDependencies": { + "@dfinity/principal": "^0.18.1" } }, "packages/candid/node_modules/brace-expansion": { diff --git a/packages/assets/package.json b/packages/assets/package.json index 44d6e94f0..d973406d1 100644 --- a/packages/assets/package.json +++ b/packages/assets/package.json @@ -51,6 +51,7 @@ }, "peerDependencies": { "@dfinity/agent": "^0.18.1", + "@dfinity/principal": "^0.18.1", "js-sha256": "0.9.0" }, "dependencies": { diff --git a/packages/candid/package.json b/packages/candid/package.json index 189f64c20..c300479f9 100644 --- a/packages/candid/package.json +++ b/packages/candid/package.json @@ -47,6 +47,9 @@ "test": "jest", "test:coverage": "jest --verbose --collectCoverage" }, + "peerDependencies": { + "@dfinity/principal": "^0.18.1" + }, "devDependencies": { "@types/jest": "^28.1.4", "@typescript-eslint/eslint-plugin": "^5.30.5", From 5847bc8644963088d090d2a66faa7fcefd39d5a5 Mon Sep 17 00:00:00 2001 From: Hamish Peebles Date: Tue, 15 Aug 2023 15:25:06 +0100 Subject: [PATCH 2/2] Update changelog --- docs/generated/changelog.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/generated/changelog.html b/docs/generated/changelog.html index 164d6c2e2..895775af7 100644 --- a/docs/generated/changelog.html +++ b/docs/generated/changelog.html @@ -12,6 +12,7 @@

Agent-JS Changelog

Version x.x.x

    +
  • Fix: add `@dfinity/principal` as a peerDependency to `assets` and `candid`.
  • Feat: HttpAgent now uses a default address of https://icp-api.io. Users will be warned for not setting a host, but the code will default to mainnet.