Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sort parameter in pageables of the services #44

Open
trivesc opened this issue Nov 19, 2019 · 0 comments
Open

Missing sort parameter in pageables of the services #44

trivesc opened this issue Nov 19, 2019 · 0 comments
Labels

Comments

@trivesc
Copy link
Member

trivesc commented Nov 19, 2019

Category: Bug
Severity: High

With new versions of devon4j it seems that its necessary to have a sort inside the pageable, even if its empty. This part of the explanation seems missing both in frontend and backend.
For example:

 getCurrentlyAttendedAccessCode(): Observable<AccessCode> {
    const filters: FilterAccessCode = new FilterAccessCode();
    const pageable: Pageable = new Pageable();

    filters.endTime = null;
    pageable.pageNumber = 0;
    pageable.pageSize = 1;
    pageable.sort = new Array();
    filters.pageable = pageable;

This means the interface has to change too:

export class Pageable {
    pageSize: number;
    pageNumber: number;
    sort: Sort[];
}
@trivesc trivesc added the bug label Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant