Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node version 16 breaks GitHub workflows #338

Open
GuentherJulian opened this issue Feb 16, 2022 · 0 comments
Open

Node version 16 breaks GitHub workflows #338

GuentherJulian opened this issue Feb 16, 2022 · 0 comments
Labels
bug Something isn't working high priority critical issues that should be fixed first Team_Tutorials These issues will be handeled by the team Tutorials

Comments

@GuentherJulian
Copy link
Contributor

It seems that some of the dependencies used by the tutorial compiler are not compatible with Node version 16.
See for example: https://github.com/devonfw-tutorials/tutorial-compiler/runs/5181051825?check_suite_focus=true

This caused PRs in the tutorials repository to not upload to katacoda-scenarios-dev. After downgrading to Node version 14, the pipeline ran through.
https://github.com/devonfw-tutorials/katacoda-scenarios-dev/blob/main/.github/workflows/main.yml#L25.

A quick solution would be to use Node version 14 (or 12) in all GitHub actions where the tutorial compiler is used. In some of them there is already a fixed version Node 12 used.
https://github.com/devonfw-tutorials/katacoda-scenarios-dev/blob/main/.github/workflows/main.yml
https://github.com/devonfw-tutorials/katacoda-scenarios/blob/master/.github/workflows/main.yml
https://github.com/devonfw-tutorials/katacoda-scenarios/blob/master/.github/workflows/nightlyBuild.yml
https://github.com/devonfw-tutorials/tutorials/blob/main/.github/workflows/buildMain.yml
https://github.com/devonfw-tutorials/tutorials/blob/main/.github/workflows/buildPullRequest.yml
https://github.com/devonfw-tutorials/tutorial-compiler/blob/main/.github/workflows/linuxMain.yml
https://github.com/devonfw-tutorials/tutorial-compiler/blob/main/.github/workflows/linuxPullRequest.yml
https://github.com/devonfw-tutorials/tutorial-compiler/blob/main/.github/workflows/windowsMain.yml
https://github.com/devonfw-tutorials/tutorial-compiler/blob/main/.github/workflows/windowsPullRequest.yml

A better solution would be to update the dependencies in the tutorial-compiler so that it is compatible with Node 16.

@GuentherJulian GuentherJulian added bug Something isn't working high priority critical issues that should be fixed first Team_Tutorials These issues will be handeled by the team Tutorials labels Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority critical issues that should be fixed first Team_Tutorials These issues will be handeled by the team Tutorials
Projects
None yet
Development

No branches or pull requests

1 participant