Duplicate roll numbers can be added in add_student due to incorrect comparison of roll numbers as strings instead of integers.

[Advaitgaur004]

Description

The add_student function does not properly check for duplicate roll numbers due to incorrect comparison of roll numbers as strings instead of integers, allowing duplicates to be added.

Files

List the relevant files associated with this issue. This will guide contributors in navigating the project effectively and provide clues on where to start.

• student_management.py

To Reproduce

1. Initialize the StudentManagementSystem class.
2. Call the add_student method with a roll number as a string (e.g., "001").
3. Call the add_student method again with the same roll number as an integer (e.g., 1).
4. Observe that both students are added despite having the same roll number.

Expected Behavior

The add_student function should reject the addition of a new student with a roll number that already exists in the system.

Actual Behavior

The function accepts both roll numbers as different due to string comparison, allowing duplicate entries.

Tasks

• Modify the duplicate roll number check in the add_student method to compare roll numbers as integers.
• Update any affected tests or add new ones if necessary.

Possible Fixes

Change the comparison in add_student fromstr(student.roll_no) == str(roll_no) to student.roll_no == roll_no to ensure both are compared as integers.